ADR-026: Client-Side Logging + linting fixes

src/hooks/useFlyerUploader.ts

@@ -2,15 +2,9 @@
 // src/hooks/useFlyerUploader.ts
 import { useState, useCallback, useMemo } from 'react';
 import { useQuery, useMutation, useQueryClient } from '@tanstack/react-query';
-import {
-  uploadAndProcessFlyer,
-  getJobStatus,
-  type JobStatus,
-  JobFailedError,
-} from '../services/aiApiClient';
+import { uploadAndProcessFlyer, getJobStatus, type JobStatus } from '../services/aiApiClient';
 import { logger } from '../services/logger.client';
 import { generateFileChecksum } from '../utils/checksum';
-import type { ProcessingStage } from '../types';
 
 export type ProcessingState = 'idle' | 'uploading' | 'polling' | 'completed' | 'error';
 
@@ -105,7 +99,7 @@ export const useFlyerUploader = () => {
 
   // Consolidate state derivation for the UI from the react-query hooks using useMemo.
   // This improves performance by memoizing the derived state and makes the logic easier to follow.
-  const { processingState, errorMessage, duplicateFlyerId, flyerId, statusMessage } = useMemo(() => {
+  const { processingState, errorMessage, duplicateFlyerId, flyerId } = useMemo(() => {
     // The order of these checks is critical. Errors must be checked first to override
     // any stale `jobStatus` from a previous successful poll.
     const state: ProcessingState = (() => {
@@ -150,7 +144,7 @@ export const useFlyerUploader = () => {
       processingState: state,
       errorMessage: msg,
       duplicateFlyerId: dupId,
-      flyerId: jobStatus?.state === 'completed' ? jobStatus.returnValue?.flyerId ?? null : null,
+      flyerId: jobStatus?.state === 'completed' ? (jobStatus.returnValue?.flyerId ?? null) : null,
       statusMessage: uploadMutation.isPending ? 'Uploading file...' : jobStatus?.progress?.message,
     };
   }, [uploadMutation, jobStatus, pollError]);

src/hooks/useShoppingLists.tsx

@@ -9,6 +9,7 @@ import {
   useUpdateShoppingListItemMutation,
   useRemoveShoppingListItemMutation,
 } from './mutations';
+import { logger } from '../services/logger.client';
 import type { ShoppingListItem } from '../types';
 
 /**
@@ -84,7 +85,7 @@ const useShoppingListsHook = () => {
         await createListMutation.mutateAsync({ name });
       } catch (error) {
         // Error is already handled by the mutation hook (notification shown)
-        console.error('useShoppingLists: Failed to create list', error);
+        logger.error({ err: error }, '[useShoppingLists] Failed to create list');
       }
     },
     [userProfile, createListMutation],
@@ -102,7 +103,7 @@ const useShoppingListsHook = () => {
         await deleteListMutation.mutateAsync({ listId });
       } catch (error) {
         // Error is already handled by the mutation hook (notification shown)
-        console.error('useShoppingLists: Failed to delete list', error);
+        logger.error({ err: error }, '[useShoppingLists] Failed to delete list');
       }
     },
     [userProfile, deleteListMutation],
@@ -123,7 +124,7 @@ const useShoppingListsHook = () => {
         await addItemMutation.mutateAsync({ listId, item });
       } catch (error) {
         // Error is already handled by the mutation hook (notification shown)
-        console.error('useShoppingLists: Failed to add item', error);
+        logger.error({ err: error }, '[useShoppingLists] Failed to add item');
       }
     },
     [userProfile, addItemMutation],
@@ -141,7 +142,7 @@ const useShoppingListsHook = () => {
         await updateItemMutation.mutateAsync({ itemId, updates });
       } catch (error) {
         // Error is already handled by the mutation hook (notification shown)
-        console.error('useShoppingLists: Failed to update item', error);
+        logger.error({ err: error }, '[useShoppingLists] Failed to update item');
       }
     },
     [userProfile, updateItemMutation],
@@ -159,7 +160,7 @@ const useShoppingListsHook = () => {
         await removeItemMutation.mutateAsync({ itemId });
       } catch (error) {
         // Error is already handled by the mutation hook (notification shown)
-        console.error('useShoppingLists: Failed to remove item', error);
+        logger.error({ err: error }, '[useShoppingLists] Failed to remove item');
       }
     },
     [userProfile, removeItemMutation],

src/hooks/useWatchedItems.tsx

@@ -3,6 +3,7 @@ import { useMemo, useCallback } from 'react';
 import { useAuth } from '../hooks/useAuth';
 import { useUserData } from '../hooks/useUserData';
 import { useAddWatchedItemMutation, useRemoveWatchedItemMutation } from './mutations';
+import { logger } from '../services/logger.client';
 
 /**
  * A custom hook to manage all state and logic related to a user's watched items.
@@ -43,7 +44,7 @@ const useWatchedItemsHook = () => {
       } catch (error) {
         // Error is already handled by the mutation hook (notification shown)
         // Just log for debugging
-        console.error('useWatchedItems: Failed to add item', error);
+        logger.error({ err: error }, '[useWatchedItems] Failed to add item');
       }
     },
     [userProfile, addWatchedItemMutation],
@@ -62,7 +63,7 @@ const useWatchedItemsHook = () => {
       } catch (error) {
         // Error is already handled by the mutation hook (notification shown)
         // Just log for debugging
-        console.error('useWatchedItems: Failed to remove item', error);
+        logger.error({ err: error }, '[useWatchedItems] Failed to remove item');
       }
     },
     [userProfile, removeWatchedItemMutation],