refactor: update API response handling across multiple queries to ensure compliance with ADR-028
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 16m53s
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 16m53s
- Removed direct return of json.data in favor of structured error handling. - Implemented checks for success and data array in useActivityLogQuery, useBestSalePricesQuery, useBrandsQuery, useCategoriesQuery, useFlyerItemsForFlyersQuery, useFlyerItemsQuery, useFlyersQuery, useLeaderboardQuery, useMasterItemsQuery, usePriceHistoryQuery, useShoppingListsQuery, useSuggestedCorrectionsQuery, and useWatchedItemsQuery. - Updated unit tests to reflect changes in expected behavior when API response does not conform to the expected structure. - Updated package.json to use the latest version of @sentry/vite-plugin. - Adjusted vite.config.ts for local development SSL configuration. - Added self-signed SSL certificate and key for local development.
This commit is contained in:
@@ -32,8 +32,12 @@ export const useWatchedItemsQuery = (enabled: boolean) => {
|
||||
}
|
||||
|
||||
const json = await response.json();
|
||||
// API returns { success: true, data: [...] }, extract the data array
|
||||
return json.data ?? json;
|
||||
// ADR-028: API returns { success: true, data: [...] }
|
||||
// If success is false or data is not an array, return empty array to prevent .map() errors
|
||||
if (!json.success || !Array.isArray(json.data)) {
|
||||
return [];
|
||||
}
|
||||
return json.data;
|
||||
},
|
||||
enabled,
|
||||
// Keep data fresh for 1 minute since users actively manage watched items
|
||||
|
||||
Reference in New Issue
Block a user