style: auto-format code via Prettier [skip ci]
This commit is contained in:
@@ -12,13 +12,13 @@ The PM2 namespace implementation for the flyer-crawler project is now 100% compl
|
||||
|
||||
### Key Achievements
|
||||
|
||||
| Metric | Value |
|
||||
|--------|-------|
|
||||
| **Namespaces Implemented** | 3 (production, test, development) |
|
||||
| **Workflow Files Updated** | 6 |
|
||||
| **Config Files Modified** | 3 |
|
||||
| **Test Coverage** | 89 tests (all passing) |
|
||||
| **Race Conditions Eliminated** | `pm2 save` isolation complete |
|
||||
| Metric | Value |
|
||||
| ------------------------------ | --------------------------------- |
|
||||
| **Namespaces Implemented** | 3 (production, test, development) |
|
||||
| **Workflow Files Updated** | 6 |
|
||||
| **Config Files Modified** | 3 |
|
||||
| **Test Coverage** | 89 tests (all passing) |
|
||||
| **Race Conditions Eliminated** | `pm2 save` isolation complete |
|
||||
|
||||
---
|
||||
|
||||
@@ -40,11 +40,11 @@ Prior to this implementation, the project experienced critical issues with PM2 p
|
||||
|
||||
### Namespace Architecture
|
||||
|
||||
| Environment | Namespace | Config File | Use Case |
|
||||
|-------------|-----------|-------------|----------|
|
||||
| Production | `flyer-crawler-prod` | `ecosystem.config.cjs` | Live production deployment |
|
||||
| Test | `flyer-crawler-test` | `ecosystem-test.config.cjs` | Staging/test deployment |
|
||||
| Development | `flyer-crawler-dev` | `ecosystem.dev.config.cjs` | Local development in dev container |
|
||||
| Environment | Namespace | Config File | Use Case |
|
||||
| ----------- | -------------------- | --------------------------- | ---------------------------------- |
|
||||
| Production | `flyer-crawler-prod` | `ecosystem.config.cjs` | Live production deployment |
|
||||
| Test | `flyer-crawler-test` | `ecosystem-test.config.cjs` | Staging/test deployment |
|
||||
| Development | `flyer-crawler-dev` | `ecosystem.dev.config.cjs` | Local development in dev container |
|
||||
|
||||
### Namespace Definition Pattern
|
||||
|
||||
@@ -55,10 +55,10 @@ Each ecosystem config defines its namespace at the module.exports level (not ins
|
||||
module.exports = {
|
||||
namespace: 'flyer-crawler-prod',
|
||||
apps: [
|
||||
{ name: 'flyer-crawler-api', /* ... */ },
|
||||
{ name: 'flyer-crawler-worker', /* ... */ },
|
||||
{ name: 'flyer-crawler-analytics-worker', /* ... */ }
|
||||
]
|
||||
{ name: 'flyer-crawler-api' /* ... */ },
|
||||
{ name: 'flyer-crawler-worker' /* ... */ },
|
||||
{ name: 'flyer-crawler-analytics-worker' /* ... */ },
|
||||
],
|
||||
};
|
||||
```
|
||||
|
||||
@@ -68,22 +68,22 @@ module.exports = {
|
||||
|
||||
### Ecosystem Configuration Files
|
||||
|
||||
| File | Change |
|
||||
|------|--------|
|
||||
| `ecosystem.config.cjs` | Added `namespace: 'flyer-crawler-prod'` at module.exports level |
|
||||
| File | Change |
|
||||
| --------------------------- | --------------------------------------------------------------- |
|
||||
| `ecosystem.config.cjs` | Added `namespace: 'flyer-crawler-prod'` at module.exports level |
|
||||
| `ecosystem-test.config.cjs` | Added `namespace: 'flyer-crawler-test'` at module.exports level |
|
||||
| `ecosystem.dev.config.cjs` | Added `namespace: 'flyer-crawler-dev'` at module.exports level |
|
||||
| `ecosystem.dev.config.cjs` | Added `namespace: 'flyer-crawler-dev'` at module.exports level |
|
||||
|
||||
### Workflow Files
|
||||
|
||||
| File | Changes |
|
||||
|------|---------|
|
||||
| `.gitea/workflows/deploy-to-prod.yml` | Added `--namespace flyer-crawler-prod` to all PM2 commands |
|
||||
| `.gitea/workflows/deploy-to-test.yml` | Added `--namespace flyer-crawler-test` to all PM2 commands |
|
||||
| `.gitea/workflows/restart-pm2.yml` | Added `--namespace` flags for both test and production environments |
|
||||
| `.gitea/workflows/manual-db-restore.yml` | Added `--namespace flyer-crawler-prod` to PM2 stop, save, and startOrReload commands |
|
||||
| `.gitea/workflows/manual-deploy-major.yml` | Added `--namespace flyer-crawler-prod` to PM2 commands |
|
||||
| `.gitea/workflows/pm2-diagnostics.yml` | Added namespace-specific sections for both production and test |
|
||||
| File | Changes |
|
||||
| ------------------------------------------ | ------------------------------------------------------------------------------------ |
|
||||
| `.gitea/workflows/deploy-to-prod.yml` | Added `--namespace flyer-crawler-prod` to all PM2 commands |
|
||||
| `.gitea/workflows/deploy-to-test.yml` | Added `--namespace flyer-crawler-test` to all PM2 commands |
|
||||
| `.gitea/workflows/restart-pm2.yml` | Added `--namespace` flags for both test and production environments |
|
||||
| `.gitea/workflows/manual-db-restore.yml` | Added `--namespace flyer-crawler-prod` to PM2 stop, save, and startOrReload commands |
|
||||
| `.gitea/workflows/manual-deploy-major.yml` | Added `--namespace flyer-crawler-prod` to PM2 commands |
|
||||
| `.gitea/workflows/pm2-diagnostics.yml` | Added namespace-specific sections for both production and test |
|
||||
|
||||
### Session-Specific Modifications (2026-02-18)
|
||||
|
||||
@@ -103,16 +103,16 @@ The following files were modified in the final session to ensure complete namesp
|
||||
|
||||
### Migration Script
|
||||
|
||||
| File | Purpose |
|
||||
|------|---------|
|
||||
| File | Purpose |
|
||||
| ----------------------------------- | ------------------------------------------------------------------------------- |
|
||||
| `scripts/migrate-pm2-namespaces.sh` | Zero-downtime migration script for transitioning servers to namespace-based PM2 |
|
||||
|
||||
### Documentation
|
||||
|
||||
| File | Purpose |
|
||||
|------|---------|
|
||||
| `docs/adr/0063-pm2-namespace-implementation.md` | Architecture Decision Record documenting the design |
|
||||
| `CLAUDE.md` | Updated PM2 Namespace Isolation section with usage examples |
|
||||
| File | Purpose |
|
||||
| ----------------------------------------------- | ----------------------------------------------------------- |
|
||||
| `docs/adr/0063-pm2-namespace-implementation.md` | Architecture Decision Record documenting the design |
|
||||
| `CLAUDE.md` | Updated PM2 Namespace Isolation section with usage examples |
|
||||
|
||||
---
|
||||
|
||||
@@ -173,6 +173,7 @@ Total: **89 tests** (all passing)
|
||||
### 1. Race Condition Elimination
|
||||
|
||||
Before:
|
||||
|
||||
```
|
||||
Test deploy: pm2 save -> writes to ~/.pm2/dump.pm2
|
||||
Prod deploy: pm2 save -> overwrites ~/.pm2/dump.pm2
|
||||
@@ -180,6 +181,7 @@ PM2 daemon restart -> incomplete process list
|
||||
```
|
||||
|
||||
After:
|
||||
|
||||
```
|
||||
Test deploy: pm2 save --namespace flyer-crawler-test -> writes to ~/.pm2/dump-flyer-crawler-test.pm2
|
||||
Prod deploy: pm2 save --namespace flyer-crawler-prod -> writes to ~/.pm2/dump-flyer-crawler-prod.pm2
|
||||
@@ -189,6 +191,7 @@ PM2 daemon restart -> both environments fully restored
|
||||
### 2. Safe Parallel Deployments
|
||||
|
||||
Test and production deployments can now run simultaneously without interference. Each namespace operates independently with its own:
|
||||
|
||||
- Process list
|
||||
- Dump file
|
||||
- Logs (when using namespace filter)
|
||||
@@ -196,16 +199,18 @@ Test and production deployments can now run simultaneously without interference.
|
||||
### 3. Simplified Commands
|
||||
|
||||
Before (with filtering logic):
|
||||
|
||||
```javascript
|
||||
// Complex inline JavaScript filtering
|
||||
const list = JSON.parse(execSync('pm2 jlist').toString());
|
||||
const prodProcesses = list.filter(p =>
|
||||
['flyer-crawler-api', 'flyer-crawler-worker', 'flyer-crawler-analytics-worker'].includes(p.name)
|
||||
const prodProcesses = list.filter((p) =>
|
||||
['flyer-crawler-api', 'flyer-crawler-worker', 'flyer-crawler-analytics-worker'].includes(p.name),
|
||||
);
|
||||
prodProcesses.forEach(p => execSync(`pm2 delete ${p.pm_id}`));
|
||||
prodProcesses.forEach((p) => execSync(`pm2 delete ${p.pm_id}`));
|
||||
```
|
||||
|
||||
After (simple namespace flag):
|
||||
|
||||
```bash
|
||||
pm2 delete all --namespace flyer-crawler-prod
|
||||
```
|
||||
@@ -347,13 +352,13 @@ pm2 list # Should show processes organized by namespace
|
||||
|
||||
## Related Documentation
|
||||
|
||||
| Document | Purpose |
|
||||
|----------|---------|
|
||||
| [ADR-063: PM2 Namespace Implementation](../adr/0063-pm2-namespace-implementation.md) | Architecture decision record |
|
||||
| [ADR-061: PM2 Process Isolation Safeguards](../adr/0061-pm2-process-isolation-safeguards.md) | Prior safeguards (still active) |
|
||||
| [CLAUDE.md](../../CLAUDE.md) | PM2 Namespace Isolation section (lines 52-169) |
|
||||
| [PM2 Incident Response Runbook](./PM2-INCIDENT-RESPONSE.md) | Emergency procedures |
|
||||
| [Incident Report 2026-02-17](./INCIDENT-2026-02-17-PM2-PROCESS-KILL.md) | Root cause analysis |
|
||||
| Document | Purpose |
|
||||
| -------------------------------------------------------------------------------------------- | ---------------------------------------------- |
|
||||
| [ADR-063: PM2 Namespace Implementation](../adr/0063-pm2-namespace-implementation.md) | Architecture decision record |
|
||||
| [ADR-061: PM2 Process Isolation Safeguards](../adr/0061-pm2-process-isolation-safeguards.md) | Prior safeguards (still active) |
|
||||
| [CLAUDE.md](../../CLAUDE.md) | PM2 Namespace Isolation section (lines 52-169) |
|
||||
| [PM2 Incident Response Runbook](./PM2-INCIDENT-RESPONSE.md) | Emergency procedures |
|
||||
| [Incident Report 2026-02-17](./INCIDENT-2026-02-17-PM2-PROCESS-KILL.md) | Root cause analysis |
|
||||
|
||||
---
|
||||
|
||||
@@ -373,16 +378,16 @@ pm2 list # Should show processes organized by namespace
|
||||
|
||||
## Appendix: Command Quick Reference
|
||||
|
||||
| Action | Production | Test |
|
||||
|--------|------------|------|
|
||||
| Start | `pm2 start ecosystem.config.cjs --namespace flyer-crawler-prod` | `pm2 start ecosystem-test.config.cjs --namespace flyer-crawler-test` |
|
||||
| Stop all | `pm2 stop all --namespace flyer-crawler-prod` | `pm2 stop all --namespace flyer-crawler-test` |
|
||||
| Restart all | `pm2 restart all --namespace flyer-crawler-prod` | `pm2 restart all --namespace flyer-crawler-test` |
|
||||
| Delete all | `pm2 delete all --namespace flyer-crawler-prod` | `pm2 delete all --namespace flyer-crawler-test` |
|
||||
| List | `pm2 list --namespace flyer-crawler-prod` | `pm2 list --namespace flyer-crawler-test` |
|
||||
| Logs | `pm2 logs --namespace flyer-crawler-prod` | `pm2 logs --namespace flyer-crawler-test` |
|
||||
| Save | `pm2 save --namespace flyer-crawler-prod` | `pm2 save --namespace flyer-crawler-test` |
|
||||
| Describe | `pm2 describe flyer-crawler-api --namespace flyer-crawler-prod` | `pm2 describe flyer-crawler-api-test --namespace flyer-crawler-test` |
|
||||
| Action | Production | Test |
|
||||
| ----------- | --------------------------------------------------------------- | -------------------------------------------------------------------- |
|
||||
| Start | `pm2 start ecosystem.config.cjs --namespace flyer-crawler-prod` | `pm2 start ecosystem-test.config.cjs --namespace flyer-crawler-test` |
|
||||
| Stop all | `pm2 stop all --namespace flyer-crawler-prod` | `pm2 stop all --namespace flyer-crawler-test` |
|
||||
| Restart all | `pm2 restart all --namespace flyer-crawler-prod` | `pm2 restart all --namespace flyer-crawler-test` |
|
||||
| Delete all | `pm2 delete all --namespace flyer-crawler-prod` | `pm2 delete all --namespace flyer-crawler-test` |
|
||||
| List | `pm2 list --namespace flyer-crawler-prod` | `pm2 list --namespace flyer-crawler-test` |
|
||||
| Logs | `pm2 logs --namespace flyer-crawler-prod` | `pm2 logs --namespace flyer-crawler-test` |
|
||||
| Save | `pm2 save --namespace flyer-crawler-prod` | `pm2 save --namespace flyer-crawler-test` |
|
||||
| Describe | `pm2 describe flyer-crawler-api --namespace flyer-crawler-prod` | `pm2 describe flyer-crawler-api-test --namespace flyer-crawler-test` |
|
||||
|
||||
---
|
||||
|
||||
|
||||
Reference in New Issue
Block a user