Commit Graph

71 Commits

Author SHA1 Message Date
de5425ef91 more refactor
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
2025-12-21 21:14:22 -08:00
bc2c24bcff more refactor
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
2025-12-21 20:34:32 -08:00
15f759cbc4 more unit test fixes + some integration
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 1h21m56s
2025-12-21 14:54:41 -08:00
0cf4ca02b7 large mock refector hopefully done + no errors?
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 1h19m21s
2025-12-21 12:38:53 -08:00
9d5fea19b2 large mock refector hopefully done + no errors?
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 1h17m3s
2025-12-21 10:47:58 -08:00
c49e5f7019 large mock refector hopefully done + no errors?
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 1h13m59s
2025-12-21 02:43:03 -08:00
391d00ae15 more test fixes
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 1h8m48s
2025-12-20 19:40:49 -08:00
56981236ab ensure mocks are used wherever possible, more test fixes
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 1h7m5s
2025-12-20 15:33:08 -08:00
bf4646fbe5 fix ing the mock mock mock !
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 1h4m27s
2025-12-20 11:50:21 -08:00
a3d3ddd772 mock mock mock !
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 57m50s
2025-12-19 20:31:04 -08:00
e62739810e moar fixes + unit test review of routes
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 57m53s
2025-12-19 14:20:22 -08:00
7b1b67d2ed MORE UNIT TESTS - approx 94% before - 96% now?
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 54m59s
2025-12-19 03:07:50 -08:00
68ee9a4663 MORE UNIT TESTS - approc 94% before - 96% now?
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 53m9s
2025-12-18 20:09:04 -08:00
07df85f72f unit test fixes
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 48m56s
2025-12-18 17:51:12 -08:00
7a557b5648 unit test fixes
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 44m36s
2025-12-18 15:35:02 -08:00
0d91c58299 unit test fixes
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 43m18s
2025-12-18 10:24:17 -08:00
c623cddfb5 MORE UNIT TESTS - approc 90% before - 95% now?
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 45m25s
2025-12-17 20:57:28 -08:00
6c17f202ed refactor AI Analysis system
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 39m7s
2025-12-17 17:00:11 -08:00
711f65003a one moar time - we can do it? 3 errors now
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
2025-12-17 16:27:27 -08:00
792bf7f237 one moar time - we can do it? 4 errors now
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 38m18s
2025-12-17 14:44:23 -08:00
13bdf1b76e one moar time - we can do it?
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 35m48s
2025-12-17 12:03:02 -08:00
ed2eb1743e one moar time - we can do it?
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 34m45s
2025-12-17 10:49:46 -08:00
d3ad50cde6 one moar time - we can do it?
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 32m32s
2025-12-17 04:49:01 -08:00
a25eafc062 Refactor: Add @testing-library/user-event dependency and enhance tests with improved logging and error handling for better clarity and maintainability
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 31m47s
2025-12-16 18:50:45 -08:00
a64e74f61d Refactor: Enhance logging and error handling in useAiAnalysis and AdminBrandManager for improved clarity and maintainability
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 28m42s
2025-12-16 14:09:36 -08:00
4277adac75 Refactor: Improve logging and error handling in tests and components for better clarity and maintainability
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 25m9s
2025-12-16 12:44:26 -08:00
f34c66bab1 Refactor: Enhance logging and error handling in FlyerUploader, AuthProvider, and checksum utilities for improved debugging and maintainability
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 17m58s
2025-12-16 01:07:22 -08:00
d1cd0b332e Refactor: Improve test assertions and error messages in useAuth and recipe routes tests for clarity
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 15m14s
2025-12-15 23:31:59 -08:00
08340a4cf2 Refactor: Introduce requiredString helper for consistent validation across routes and services
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 8m21s
2025-12-15 19:19:23 -08:00
d5f185ad99 Refactor tests and improve error handling across various services
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 10m38s
- Updated `useAuth` tests to use async functions for JSON responses to avoid promise resolution issues.
- Changed `AdminBrandManager` tests to use `mockImplementation` for consistent mock behavior.
- Enhanced `ProfileManager.Authenticated` tests to ensure proper error handling and assertions for partial updates.
- Modified `SystemCheck` tests to prevent memory leaks by using `mockImplementation` for API calls.
- Improved error handling in `ai.routes.ts` by refining validation schemas and adding error extraction utility.
- Updated `auth.routes.test.ts` to inject mock logger for better error tracking.
- Refined `flyer.routes.ts` to ensure proper validation and error handling for flyer ID parameters.
- Enhanced `admin.db.ts` to ensure specific errors are re-thrown for better error management.
- Updated `budget.db.test.ts` to improve mock behavior and ensure accurate assertions.
- Refined `flyer.db.ts` to improve error handling for race conditions during store creation.
- Enhanced `notification.db.test.ts` to ensure specific error types are tested correctly.
- Updated `recipe.db.test.ts` to ensure proper handling of not found errors.
- Improved `user.db.ts` to ensure consistent error handling for user retrieval.
- Enhanced `flyerProcessingService.server.test.ts` to ensure accurate assertions on transformed data.
- Updated `logger.server.ts` to disable transport in test environments to prevent issues.
- Refined `queueService.workers.test.ts` to ensure accurate mocking of email service.
- Improved `userService.test.ts` to ensure proper mock implementations for repository classes.
- Enhanced `checksum.test.ts` to ensure reliable file content creation in tests.
- Updated `pdfConverter.test.ts` to reset shared state objects and mock implementations before each test.
2025-12-15 16:40:13 -08:00
0c590675b3 Refactor and enhance error handling across various routes and hooks
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 9m29s
- Added error logging for image generation in useAiAnalysis hook.
- Updated useAuth tests to relax strict call count checks for compatibility with React Strict Mode.
- Improved user data tests to handle multiple renders and mock API responses more effectively.
- Enhanced watched items tests to ensure isolation and proper mock behavior.
- Updated validation middleware tests to accommodate potential variations in error messages.
- Removed flaky test for invalid job ID format in AI routes due to routing limitations.
- Adjusted auth routes tests to check for error messages in a more resilient manner.
- Improved flyer routes to ensure proper validation and error handling.
- Enhanced gamification routes tests to check for error messages using regex for flexibility.
- Updated recipe routes to ensure type safety and proper error handling for query parameters.
- Enhanced stats routes to ensure proper validation and error handling for query parameters.
- Improved system routes tests to accommodate variations in validation error messages.
- Updated user routes tests to ensure proper validation and error handling for various scenarios.
- Refactored user routes to ensure type safety and proper handling of query parameters.
2025-12-15 11:43:52 -08:00
2a79f31af3 Refactor: Enhance test mocks and assertions for improved clarity and structure across multiple test files
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 7m24s
2025-12-15 04:38:19 -08:00
c533521021 Refactor: Improve test structure and mock implementations across multiple test files
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 7m21s
2025-12-15 03:44:57 -08:00
066933ff6d Refactor: Update FlyerCountDisplay tests to use useFlyers hook and FlyersProvider
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 7m0s
2025-12-15 00:19:51 -08:00
6e8a8343e0 Refactor tests and API context integration
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 5m55s
- Updated tests in `useShoppingLists`, `useWatchedItems`, and various components to use `waitFor` for asynchronous assertions.
- Enhanced error handling in `errorHandler` middleware tests to include validation errors and status codes.
- Modified `AuthView`, `ProfileManager.Auth`, and `ProfileManager.Authenticated` tests to check for `AbortSignal` in API calls.
- Removed duplicate assertions in `auth.routes.test`, `budget.routes.test`, and `gamification.routes.test`.
- Introduced reusable logger matcher in `budget.routes.test`, `deals.routes.test`, `flyer.routes.test`, and `user.routes.test`.
- Simplified API client mock in `aiApiClient.test` to handle token overrides correctly.
- Removed unused `apiUtils.ts` file.
- Added `ApiContext` and `ApiProvider` for better API client management in React components.
2025-12-14 23:28:58 -08:00
69e2287870 linting done now fix unit tests
All checks were successful
Deploy to Test Environment / deploy-to-test (push) Successful in 8m19s
2025-12-14 21:48:53 -08:00
43ca7f9df2 Refactor context and provider structure for improved organization and maintainability
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
- Removed individual context files for Auth, Flyers, MasterItems, Modal, UserData, and their respective hooks.
- Introduced centralized provider files for each context, encapsulating logic and state management.
- Updated imports across the application to reflect the new structure, ensuring all hooks and contexts are correctly referenced.
- Enhanced the AppProviders component to streamline the wrapping of all context providers in the application.
- Improved type definitions and context management for better type safety and clarity.
2025-12-14 21:00:58 -08:00
82b7ce82e7 refactor: Add custom hooks for context access in various contexts
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
2025-12-14 20:24:18 -08:00
8274f4c871 Refactor hooks and contexts for improved state management and modularity
Some checks are pending
Deploy to Test Environment / deploy-to-test (push) Has started running
- Updated `useActiveDeals` hook to include reset functionality for API calls.
- Enhanced `useApi` hook to provide a reset method for clearing state.
- Refactored `useAuth`, `useFlyers`, `useMasterItems`, `useModal`, and `useUserData` hooks to utilize context providers for better state management.
- Created new context files: `AuthContext`, `FlyersContext`, `MasterItemsContext`, `ModalContext`, and `UserDataContext` to encapsulate related state and logic.
- Updated tests for hooks to accommodate changes in context structure and reset functionality.
- Adjusted imports in `index.tsx` to reflect new context structure.
2025-12-14 20:08:15 -08:00
d3e546d02f refactor: Rename custom hooks for consistency and clarity
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
2025-12-14 19:32:18 -08:00
eb0e183f61 Refactor test setup and improve mock implementations
Some checks are pending
Deploy to Test Environment / deploy-to-test (push) Has started running
- Introduced `createTestApp` utility to standardize Express app creation for tests, including JSON parsing, mock logger, and error handling.
- Updated all route tests to utilize `createTestApp`, enhancing consistency and reducing boilerplate code.
- Implemented `mockLogger` for cleaner test output and easier logging mock management.
- Adjusted passport mocks to ensure proper user authentication simulation across tests.
- Enhanced type safety by augmenting Express Request interface with `req.log` and `req.user` properties.
- Removed redundant code and improved readability in various test files.
2025-12-14 14:47:19 -08:00
56f14f6342 feat: Enhance API validation and error handling across routes
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
- Added tests for invalid request bodies in price and recipe routes.
- Improved type safety in request handlers using Zod schemas.
- Introduced a consistent validation pattern for empty request bodies.
- Enhanced error messages for invalid query parameters in stats and user routes.
- Implemented middleware to inject mock logging for tests.
- Created a custom type for validated requests to streamline type inference.
2025-12-14 12:53:10 -08:00
9757f9dd9f Refactor MainLayout to use new hooks for flyers and master items; consolidate error handling
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
Update error handling tests to ensure proper status assignment for errors
2025-12-14 11:05:04 -08:00
571ca59e82 refactor: Update tests and components for improved type safety and mock handling
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Failing after 3h11m16s
2025-12-14 01:38:21 -08:00
f891da687b Refactor tests to use mockClient for database interactions, improve error handling, and enhance modal functionality
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
- Updated personalization.db.test.ts to use mockClient for query calls in addWatchedItem tests.
- Simplified error handling in shopping.db.test.ts, ensuring clearer error messages.
- Added comprehensive tests for VoiceAssistant component, including rendering and interaction tests.
- Introduced useModal hook with tests to manage modal state effectively.
- Created deals.db.test.ts to test deals repository functionality with mocked database interactions.
- Implemented error handling tests for custom error classes in errors.db.test.ts.
- Developed googleGeocodingService.server.test.ts to validate geocoding service behavior with mocked fetch.
2025-12-14 01:12:33 -08:00
7615d7746e feat: Enhance logging and type safety across various components and services
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
2025-12-13 23:12:50 -08:00
77454b04c2 Add comprehensive tests for hooks, middleware, and routes
Some checks are pending
Deploy to Test Environment / deploy-to-test (push) Has started running
- Implement tests for `useFlyers`, `useMasterItems`, `useModal`, `useUserData` hooks to ensure correct functionality and error handling.
- Create tests for `fileUpload.middleware` and `validation.middleware` to validate file uploads and request data.
- Add tests for `AddressForm` and `AuthView` components to verify rendering, user interactions, and API calls.
- Develop tests for `deals.routes` to check authentication and response for best prices on watched items.
2025-12-13 21:30:43 -08:00
2affda25dc Refactor geocoding services and improve logging
- Updated the Nominatim geocoding service to use a class-based structure and accept a logger instance for better logging control.
- Modified tests for the Nominatim service to align with the new structure and improved logging assertions.
- Removed the disabled notification service test file.
- Added a new GeocodingFailedError class to handle geocoding failures more explicitly.
- Enhanced error logging in the queue service to include structured error objects.
- Updated user service to accept a logger instance for better logging in address upsert operations.
- Added request-scoped logger to Express Request interface for type-safe logging in route handlers.
- Improved logging in utility functions for better debugging and error tracking.
- Created a new GoogleGeocodingService class for Google Maps geocoding with structured logging.
- Added tests for the useAiAnalysis hook to ensure proper functionality and error handling.
2025-12-13 17:52:30 -08:00
728f4a5f7e Refactor useWatchedItems hook to utilize useApi for API calls, update tests accordingly
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Failing after 18m15s
- Replaced direct API calls in useWatchedItems with useApi hook for add and remove watched items.
- Updated tests for useWatchedItems to mock useApi and verify API interactions.
- Consolidated error handling for API calls in useWatchedItems.
- Adjusted related hooks and components to ensure compatibility with the new structure.
- Added new ScaleIcon component for UI consistency.
- Implemented useFlyerItems and useFlyers hooks for fetching flyer data.
- Created useMasterItems and useUserData hooks for managing master grocery items and user data.
- Developed useInfiniteQuery hook for handling paginated API responses.
- Added comprehensive tests for useApi and useInfiniteQuery hooks.
- Introduced comparePrices API endpoint and corresponding client-side functionality.
2025-12-13 08:57:15 -08:00
8b06a66b17 testing ADR - architectural decisions
Some checks failed
Deploy to Test Environment / deploy-to-test (push) Has been cancelled
2025-12-12 00:01:35 -08:00